Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More lazy fixes #2450

Merged
merged 4 commits into from
Jun 27, 2024
Merged

More lazy fixes #2450

merged 4 commits into from
Jun 27, 2024

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented Jun 10, 2024

Description

A few more updates to avoid realizing data when applying fixes.

Related to #674.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.61%. Comparing base (ee16a95) to head (eebfc2f).
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2450      +/-   ##
==========================================
- Coverage   94.62%   94.61%   -0.01%     
==========================================
  Files         246      246              
  Lines       14055    14045      -10     
==========================================
- Hits        13299    13289      -10     
  Misses        756      756              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouweandela bouweandela marked this pull request as ready for review June 10, 2024 15:25
@bouweandela bouweandela added the dask related to improvements using Dask label Jun 10, 2024
@bouweandela bouweandela requested review from schlunma June 12, 2024 15:19
Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚽ 🍺

esmvalcore/cmor/_fixes/cmip6/fgoals_g3.py Show resolved Hide resolved
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I also have no idea why that tos fix was written like that and if we need it...

esmvalcore/cmor/_fixes/cmip6/fgoals_g3.py Show resolved Hide resolved
@schlunma
Copy link
Contributor

Apparently a line is too long now, could you fix that? Then I will merge

@schlunma schlunma merged commit d472381 into main Jun 27, 2024
6 checks passed
@schlunma schlunma deleted the more-lazy-fixes branch June 27, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask related to improvements using Dask
Projects
Development

Successfully merging this pull request may close these issues.

3 participants