-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More lazy fixes #2450
More lazy fixes #2450
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2450 +/- ##
==========================================
- Coverage 94.62% 94.61% -0.01%
==========================================
Files 246 246
Lines 14055 14045 -10
==========================================
- Hits 13299 13289 -10
Misses 756 756 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚽ 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I also have no idea why that tos
fix was written like that and if we need it...
Apparently a line is too long now, could you fix that? Then I will merge |
Description
A few more updates to avoid realizing data when applying fixes.
Related to #674.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: