Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use miniforge3 for our docker builds instead of mambaforge #2558

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Oct 16, 2024

Description

Missed this in #2556 - this is the last but on Mambaforge apart from the RTD wait


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@valeriupredoi valeriupredoi added the installation Installation problem label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (e69ec5d) to head (decd828).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2558   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         251      251           
  Lines       14268    14268           
=======================================
  Hits        13557    13557           
  Misses        711      711           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bettina-gier bettina-gier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beep-boop your seal of approval has surfaced from the waters. It has grepped the Core as well to see that there are no more mambaforge fishes to catch other than the readthedocs which requires external support first.

@valeriupredoi
Copy link
Contributor Author

many thanks, Seal Of Approval 🦭

@valeriupredoi valeriupredoi merged commit f622e40 into main Oct 16, 2024
7 checks passed
@valeriupredoi valeriupredoi deleted the docker_no_Mambaforge branch October 16, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants