-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ERA5 data in native format #358
Conversation
TODO:
|
@bouweandela and I addressed the remaining issues above, and this PR is now ready for review. Verifying the output against old cmorizer, I found some differences that I think are actually better in the new version than in the old cmorizer:
PS: Failing circleci tests are addressed in #452 |
Asking @valeriupredoi to have a look at the changes in |
All variables successfully tested, except |
Thanks @mattiarighi ! I removed monthly/orog because all we use it for is to create an fx variable out of it, and since we're doing that for hourly already, we don't need it in daily and monthly as well. |
@valeriupredoi are you ok with this? |
looking at it right now, hold yer horses 🐴 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK a few minor comments - has @jvegasbsc reviewed this PR yet?
I ran again with Bouwe's most recent changes and everything works fine. Think it can be merged now. |
Nice work @bouweandela, @Peter9192 and others. I want to get started with this in combination with the variable soil moisture (monthly data as provided by the CDS). Could you very briefly help me get started. E.g.: -where to put the data? (we used to put download instructions at top of the cmorization scripts, where to put them for native6? --> I would be a big fan of having this included in ESMValCore) Thanks. |
Hi Bas,
I guess we (again) failed to provide enough documentation ;-( The ESMValCore/esmvalcore/config-developer.yml Lines 191 to 201 in a9312a7
For an example recipe using ERA5, see here: https://github.com/ESMValGroup/ESMValTool/blob/master/esmvaltool/recipes/cmorizers/recipe_era5.yml |
This pull request makes it possible to use ERA5 data directly in ESMValCore. CMORization is implemented as a fix.
Related to issue ESMValGroup/ESMValTool#1120.
Related ESMValTool PR ESMValGroup/ESMValTool#1432
Tasks
yamllint
to check that your YAML files do not contain mistakesCloses #447
Also closes #311