-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Github Actions workflow to build and deploy on Test PyPi and PyPi #820
Conversation
@bouweandela do you have a |
It would probably be good to use that, since it looks like that's the future of Python packaging, see also this blog: https://snarky.ca/what-the-heck-is-pyproject-toml/ From the blog, it looks like the following content would be enough:
|
I'll try that in a jiffy, cheers dude 🍺 |
OK good news! I got the darn thing to build the wheel automatically (cheers for the pyproject file suggestion, @bouweandela ) but it looks like I have no permission to upload to Test PyPi - see test - this means that either @bouweandela hasnt added me as collaborator on Test PyPi or the Secrets have not been set correctly on ESMValCore/Settings @mattiarighi - can you guys check this by running the test yourselves pls? To trigger the test just do a dummy push to this branch |
problem solved by @bouweandela adding me to PyPi/Test PyPi 🍺 |
here is a (most probable) explanation for the failed circleCI test: pypa/pip#8437 |
From the blog:
So you'll probably need to insert that before trying to import esmvalcore._version in setup.py. Alternatively, I think you could just write a small function to read the version number from the file without importing it. |
@bouweandela you Dutch genius! How did I miss that? Yeh, does the job, but two things: the package already being on Test PyPi the upload fails (should I remove it from Test PyPi? - am scared) and PEP8 complains about the module import not being at top of file - bs if you ask me but hey, it's PEP8 |
You can't remove packages from (test) PyPI, because that's just a really bad idea. Just use a new version number for the next try, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
Automate the deployment to PyPi 🐍📦
See #814
Tasks
yamllint
to check that your YAML files do not contain mistakes