Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing global attributes for recipe_martin18grl #3637

Closed
katjaweigel opened this issue May 29, 2024 · 2 comments
Closed

Fixing global attributes for recipe_martin18grl #3637

katjaweigel opened this issue May 29, 2024 · 2 comments
Assignees
Milestone

Comments

@katjaweigel
Copy link
Contributor

Describe the bug
Due to a change in iris, global attributes can be transformed into variables attributes during preprocessing for some models. droughtindex/diag_save_spi.R does so far only write the global attributes in the resulting files. Therefor, recipe_martin18grl.yml fails, because the following python diagnostics (through ancestors) relay on the existence of the attributes. The fastest way to solve that would be to write the variable attributes in the files resulting from droughtindex/diag_save_spi.R. A better solution would be to improve also the way, information is transferred from R to python (but I don't know if I have time for this and it should be finished for the release).

See also #3616

@bouweandela
Copy link
Member

I suspect that transforming global attributes to variable attributes happens in the concatenate preprocessor function since we started using this difference introduced in iris 3.8 in ESMValGroup/ESMValCore#2398. Could you try if ESMValGroup/ESMValCore#2449 solves the issue?

@ehogan
Copy link
Contributor

ehogan commented Jun 27, 2024

This recipe passes on DKRZ using the latest versions of the ESMValCore v2.11.x release branch and the ESMValTool v2.11.x release branch (the versions dated "Jun 26, 2024"). I'll update the webpage once I have completed testing using ESMValCore v2.11.0rc2 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants