-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve cube attribute global vs local when concatenating #2449
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2449 +/- ##
=======================================
Coverage 94.61% 94.62%
=======================================
Files 246 246
Lines 14048 14055 +7
=======================================
+ Hits 13292 13299 +7
Misses 756 756 ☔ View full report in Codecov by Sentry. |
Looks good, thanks! |
@ehogan @chrisbillowsMO It might be nice to include this in the v2.11 release if possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bouwe, looks good to me!
Nice is our speciality! Cherry picked in here! |
Description
Preserve cube attribute global vs local as well as possible in
esmvalcore.preprocessor.concatenate
. Seeiris.cube.CubeAttrsDict
for more information.Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: