-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eWaterCycle: Add recipe to prepare input for HYPE #1334
eWaterCycle: Add recipe to prepare input for HYPE #1334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one change and one question. Cheers for adding this! 🍺
Could you please merge the |
…/ESMValTool into version2_development
…/ESMValTool into version2_development
circleci fails, but on existing (style) issues... |
ok, it still needs a few changes in the diag_script with respect to formatting and units.. |
@ipelupessy could you add support for the ERA5 dataset as well (see https://github.com/ESMValGroup/ESMValTool/blob/pcrglobwb_era5_recipes/esmvaltool/recipes/hydrology/recipe_pcrglobwb.yml for an example). Basically, it boils down to this:
|
@Peter9192 you zapped me from the contributors list, this breaks the recipe ;-) |
Sorry 'bout that @ipelupessy , I was under the impression that you would already be listed in my copy of the development version. It's quite annoying that there are so many versions of this file in various branches. Actually, there is an issue about this: ESMValGroup/ESMValCore#28 |
Co-Authored-By: Bouwe Andela <bouweandela@users.noreply.github.com>
…ol into version2_development
and remove unnecessary comment
Note that this possibly undoes some bonafide changes that have slipped in; this has the potential to undo the commit in a later merge. These should be carefully done
…/ESMValTool into version2_development
…/ESMValTool into version2_development
Co-Authored-By: Bouwe Andela <bouweandela@users.noreply.github.com>
@bouweandela, @valeriupredoi as far as i can see this is good to merge (but maybe I am overlooking something...) |
Short description of the diagnostic
Convert ERA-Interim and/or ERA5 meteorological input data to a format that can be used as forcing data for the HYPE hydrological model. This is part of the preprocessing workflow in the eWaterCycle project.
Tasks
yamllint
to check that your YAML files do not contain mistakesNew recipe/diagnostic
doc/sphinx/source/recipes
folder and add a new entry to index.rstCloses #1335