Splitting of flato13ipcc.yml into separate recipes and adding recipes for regional Figures

[katjaweigel]

Description

The recipe recipe_flato13ipcc.yml is split into different parts for one or few figures for easier and faster processing:

• recipe_flato13ipcc_figures_92_95.yml
• recipe_flato13ipcc_figure_96.yml
• recipe_flato13ipcc_figure_98.yml
• recipe_flato13ipcc_figure_914.yml
• recipe_flato13ipcc_figure_924.yml
• recipe_flato13ipcc_figures_926_927.yml
• recipe_flato13ipcc_figure_942.yml
• recipe_flato13ipcc_figure_945a.yml

under the common folder: recipes/ipccwg1ar5ch9/

Non working data sets are converted to comments, the data set length it fixed in one case.
The NCEP data are updated to the new data version NCEP-NCAR-R1.

Additional, recipes which cover different Regions, similar to figures of the IPCC AR5 (Flato et al., 2013) are added:

• Seasonal cycle over land within defined regions (like Fig. 9.38)
• Downscaling: Seasonal bias box plot within defined regions (like Fig. 9.39)
• Downscaling: Seasonal bias box plot within defined polar and ocean regions (like Fig. 9.40)
• Downscaling: observations versus models within defined regions (like Fig. 9.41)

The figures are add in two versions: one used to create
Figure 13-16 in https://gmd.copernicus.org/articles/14/3159/2021/
(recipe_weigel21gmd_figures_13_16.yml)
and one closer to the IPCC version
(recipe_flato13ipcc_figures_938_941_cmip6.yml)

• Closes Regional Figures for recipe recipe_flato13ipcc.yml #2155
• Link to documentation: https://github.com/ESMValGroup/ESMValTool/blob/regional_downscaling_gmddraft/doc/sphinx/source/recipes/recipe_flato13ipcc.rst
• Now in: https://esmvaltool--2156.org.readthedocs.build/en/2156/recipes/recipe_ipccwg1ar5ch9.html

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🛠 This pull request has a descriptive title
• 🛠 Code is written according to the code quality guidelines
• 🛠 Documentation is available
• 🛠 Tests run successfully
• 🛠 The list of authors is up to date
• 🛠 Any changed dependencies have been added or removed correctly
• 🛠 All checks below this pull request were successful

New or updated recipe/diagnostic

• 🧪 Recipe runs successfully
• 🧪 Recipe is well documented
• 🧪 Figure(s) and data look as expected from literature
• 🛠 Provenance information has been added

New or updated data reformatting script

- [ ] 🛠 Documentation is available
- [ ] 🛠 The dataset has been added to the CMOR check recipe
- [ ] 🧪 Numbers and units of the data look physically meaningful

---

To help with the number of pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[katjaweigel]

Thanks for the reminder, I accepted:

Please also accept or decline my suggestions for

recipe_flato13ipcc_figure_924.yml
Figure9.83.ncl
Figure9.39.cnl
Figure9.40.ncl
given three weeks ago

.
now, sorry that I overlooked them before (GitHub or my browser tends to hide them together with more than 200 other items in this PR).

[remi-kazeroni]

* recipe_flato13ipcc_figures_926_927: This also seems to be related to an ESMValCore problem giving the following error message:

ERROR   [1268254] Failed to run preprocessor function 'add_supplementary_variables' on the data
[...]
    data_dims = self._check_multi_dim_metadata(
  File "/work/bd0854/b380103/mambaforge/envs/esmvaltool-test/lib/python3.10/site-packages/iris/cube.py", line 1191, in _check_multi_dim_metadata
    raise iris.exceptions.CannotAddError(
iris.exceptions.CannotAddError: Unequal lengths. Cube dimension 1 => 64; metadata 'sea_area_fraction' dimension 0 => 192.

@remi-kazeroni Would you have an idea about the problem with recipe_flato13ipcc_figures_926_927? Here is the debug file: main_log_debug.txt

This is a consequence of ESMValGroup/ESMValCore#1609, see explanation the section on "Example with a variable that is on an unusual grid" in the description. This issue does not occur for all models but only for those like MIROC-ESM where the fgco2 variable is not on an ocean grid. The same family of models led to the same issue for the recipe_anav13jclim and was fixed in #3064 by @schlunma. I think you can just use this fix for MIROC-ESM* models.

According to the comment from @remi-kazeroni I tested with the old core and I did not see that:

No worries about that. In release periods, it is ok to use either version: the last stable release or the new release candidate. It would be ok for me if problems with the new Core are not fixed in this PR. These would be noticed later in the release process when I will run all recipes in main with the final release candidate for the Core. But it would be really nice to address easy-to-fix problems now as it makes the recipe testing simpler 👍

[remi-kazeroni]

I tested all flato recipes and recipe_weigel21_gmd_figures_13_16 once again. The following two recipes crash with ESMValCore v2.8:

• recipe_flato13ipcc__figure_98: This seems to be related to ESMValCore issue Missing preprocessed OBS data when running recipe_bock20jgr_fig_1-4 ESMValCore#1962

Yes, indeed. That seems to be the same issue with the same OBS dataset.

[katjaweigel]

I fixed the font size for Fig. 41b again and added the note to the documentation.
I'll try the new Core next, to see if I can reproduce the issue in Fig 9.39pr.

[katjaweigel]

@axel-lauer I can't reproduce the issue in Fig9.39pr, for me it also looks ok with the new Core (version pulled yesterday evening).

[axel-lauer]

@katjaweigel this is how the plots look like when I run the recipes. Please notice the differences between CMIP3 (kg m-2 s-1) and the CMIP6 version of the recipe (%). If both of your figures look fine, we could ask e.g. @LisaBock to run recipe_flato13ipcc_figures_938_941_cmip3.yml as another test...

CMIP3

CMIP6

[katjaweigel]

Ok, thanks, I only checked the CMIP6 version, I thought I updated CMIP3 as well, but maybe I overlooked something (it is selected through a setting in the recipe)

[katjaweigel]

Sorry, I did not know, that it was about CMIP3, the last commit should solve this (test is still running).

[katjaweigel]

With that change Fig9.38pr looks also ok for recipe_flato13ipcc_figures_938_941_cmip3.yml.

[axel-lauer]

Looks all fine now! Thanks for the hard work!

[katjaweigel]

Thanks @axel-lauer!

[remi-kazeroni]

Thanks for all your work @katjaweigel!! Everything looks good to me from a technical point of view. I hope you don't mind that I fixed the MIROC-ESM* entries for fgco2 in anticipation of the testing that I will do for the release of version v2.8. That would be one thing less for me to keep in mind.

This PR goes into v2.8. I will merge it to main early next week, after we have fixed automatic tests in the Tool.

[katjaweigel]

Great, thanks a lot @remi-kazeroni!