-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace recipe_era5.yml with recipe_daily_era5.yml #2182
Conversation
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is starting to look really good. I have a few more comments on the content of the documentation, but I think the structure is much improved now, especially if we get more supported datasets in the future.
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
@esmvalbot Please run cmorizers/recipe_daily_era5.yml |
Since @bouweandela asked, ESMValBot will run recipe cmorizers/recipe_daily_era5.yml as soon as possible, output will be generated here |
ESMValBot is sorry to report it failed to run recipe cmorizers/recipe_daily_era5.yml: exit is 1, output has been generated here |
It looks like the bot ran out of memory trying to run the recipe. |
The recipe also runs out of memory on a 64 GB RAM machine, even with |
The recipe (including all variables) run with and more info from and the environment file: |
If this the right place for that, would it be possible to make the list of ERA5 variables for which cmorization is supported consistent between the recipes ( Also this PR will add the MSWEP dataset to the list of supported datasets. For datasets for which we provide a specific cmorizer script, download instructions can usually be found in the script header. This is different for MSWEP for which I couldn't reproduce the steps to download. Could we work on that in this PR or should I open a specific issue for that? Thanks! |
It would be great if you could open a specific issue for MSWEP, because this pull request is really about ERA5. We tried to reorganize the documentation a bit so things are more logically organized, but let's not let this pull request grow too large. |
The memory problems occurred for me with dask version 2021.7.1 (more than 64GB required). With version 2.30.0 of dask I was able to run the recipe successfully on Mistral (max memory usage 13GB). This might be something to look out for with other recipes too, we may need to pin the dask version..
@SarahAlidoost Could you please have a look at this? Once the lists are consistent, this can be merged. |
thanks for your comment. The hourly variables in Also, now the monthly and hourly variables in
|
Please see my comment. |
@SarahAlidoost I think you can just use the usual |
@remi-kazeroni Has your comment been addressed now? |
@bouweandela yes, that looks fine for me now. Thanks @SarahAlidoost for taking my comment into account. |
Description
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
New or updated data reformatting script
To help with the number of pull requests: