Move R dependencies to environment.yml and set r-akima version
#2725
Conversation
|
My apologies, it seems we have been working on the same thing. I also worked on this in #2663, do you think it would be an option to merge that one? If you think it is too much just before a release, you could also have a look at the changes I made in there to see what is still missing here. |
| - r-docopt | ||
| - r-functional | ||
| - r-ggplot2 | ||
| - r-git2r # dependency of lintr |
There was a problem hiding this comment.
Should be removed since conda will take care of dependencies.
| - r-abind | ||
| - r-akima<=0.6-2.3 | ||
| - r-climdex.pcic | ||
| - r-ClimProjDiags | ||
| - r-docopt |
There was a problem hiding this comment.
Here, r-dotcall64 seems to be missing. Was this on purpose?
| @@ -37,9 +37,29 @@ dependencies: | |||
| - ncl | |||
| - r-base | |||
| # R packages needed for development | |||
| - r-abind | |||
| - r-akima<=0.6-2.3 | |||
There was a problem hiding this comment.
Please remember to add the pinning to https://github.com/conda-forge/esmvaltool-suite-feedstock/blob/46332d1f303b96679093b424fb0691ac39083e8b/recipe/meta.yaml#L147 when it comes to the release. Perhaps best to have an issue on the feedstock?
| - r-yaml | ||
| - r-udunits2 # needed by the docker build |
There was a problem hiding this comment.
| - r-yaml | |
| - r-udunits2 # needed by the docker build | |
| - r-udunits2 | |
| - r-yaml |
|
Sorry it seems like there is a PR mess. I closed this to take care of everything at #2663 . |
|
No worries. I saw Bouwe's comment and knew this was a risk. |
Description
This PR tries to move the R dependencies to the environment file as suggested in #2695. It also pins the akima package to the latest working version, as the newest ones break several recipes.
It would be good if someone double checked if that is what it needs to be done.
recipe_miles_*broken due to newestakimapackage versions #2695Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic
- [ ] 🧪 Recipe runs successfully- [ ] 🧪 Recipe is well documented- [ ] 🧪 Figure(s) and data look as expected from literature- [ ] 🛠 Provenance information has been addedNew or updated data reformatting script
- [ ] 🛠 Documentation is available- [ ] 🛠 The dataset has been added to the CMOR check recipe- [ ] 🧪 Numbers and units of the data look physically meaningfulTo help with the number of pull requests: