Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IPCC AR6 Chapter 3 Fig. 3.19 - Speed-Up Of Zonal Mean Wind #2984

Merged
merged 17 commits into from
Jan 27, 2023

Conversation

LisaBock
Copy link
Contributor

@LisaBock LisaBock commented Dec 26, 2022

Description

Adding IPCC AR6 Chapter 3 Fig. 3.19 - Speed-Up Of Zonal Mean Wind

Original code and a README is provided in the ESMValTool-AR6-OriginalCode-FinalFigures repository.

Docs: https://esmvaltool--2984.org.readthedocs.build/en/2984/recipes/recipe_ipccwg1ar6ch3.html


Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

New or updated recipe/diagnostic

@LisaBock
Copy link
Contributor Author

@esmvalbot Please run ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml

@esmvalbot
Copy link

esmvalbot bot commented Dec 27, 2022

Since @LisaBock asked, ESMValBot will run recipe ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Dec 27, 2022

ESMValBot is sorry to report it failed to run recipe ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml: exit is 1, output has been generated here

@LisaBock
Copy link
Contributor Author

@esmvalbot Please run ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml

@esmvalbot
Copy link

esmvalbot bot commented Jan 10, 2023

Since @LisaBock asked, ESMValBot will run recipe ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml as soon as possible, output will be generated here

@esmvalbot
Copy link

esmvalbot bot commented Jan 10, 2023

ESMValBot is sorry to report it failed to run recipe ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml: exit is 1, output has been generated here

Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the recipe, and after some trouble with writing the html-file at the very end, I managed to actually run the recipe through without trouble.
All files were produced and look ok.
The documentation is updated and seems sufficient.
I have added some suggested wording rephrases and one number (end year) correction.

Nice work, @LisaBock!

doc/sphinx/source/recipes/recipe_ipccwg1ar6ch3.rst Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_ipccwg1ar6ch3.rst Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/ipcc_ar6/zonal_westerly_winds.ncl Outdated Show resolved Hide resolved
esmvaltool/diag_scripts/ipcc_ar6/zonal_westerly_winds.ncl Outdated Show resolved Hide resolved
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and adding another AR6 recipe @LisaBock! I could run the recipe successfully and reproduce the example plot. Provenance is added, code looks good. I only have a handful minor suggestions regarding the documentation, feel free to take those into account.

esmvaltool/references/eyring21ipcc.bibtex Outdated Show resolved Hide resolved
doc/sphinx/source/recipes/recipe_ipccwg1ar6ch3.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @LisaBock! This looks good to me on the tech side. I think this can be merged once approved by @hb326 👍

Copy link
Contributor

@hb326 hb326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LisaBock for the changes! Looks all good now to me!

@schlunma
Copy link
Contributor

Thanks all! 🚀

@schlunma schlunma merged commit 56f628e into main Jan 27, 2023
@schlunma schlunma deleted the ar6_chapter_3_zonal_wind branch January 27, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants