-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding IPCC AR6 Chapter 3 Fig. 3.19 - Speed-Up Of Zonal Mean Wind #2984
Conversation
@esmvalbot Please run ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml |
ESMValBot is sorry to report it failed to run recipe ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml: exit is 1, output has been generated here |
@esmvalbot Please run ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml |
ESMValBot is sorry to report it failed to run recipe ipccwg1ar6ch3/recipe_ipccwg1ar6ch3_fig_3_19.yml: exit is 1, output has been generated here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the recipe, and after some trouble with writing the html-file at the very end, I managed to actually run the recipe through without trouble.
All files were produced and look ok.
The documentation is updated and seems sufficient.
I have added some suggested wording rephrases and one number (end year) correction.
Nice work, @LisaBock!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution and adding another AR6 recipe @LisaBock! I could run the recipe successfully and reproduce the example plot. Provenance is added, code looks good. I only have a handful minor suggestions regarding the documentation, feel free to take those into account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @LisaBock for the changes! Looks all good now to me!
Thanks all! 🚀 |
Description
Adding IPCC AR6 Chapter 3 Fig. 3.19 - Speed-Up Of Zonal Mean Wind
Original code and a README is provided in the ESMValTool-AR6-OriginalCode-FinalFigures repository.
Docs: https://esmvaltool--2984.org.readthedocs.build/en/2984/recipes/recipe_ipccwg1ar6ch3.html
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated recipe/diagnostic