Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fx_variables from ipccwg1ar5ch9 recipes #3215

Merged
merged 4 commits into from
Jun 14, 2023

Conversation

katjaweigel
Copy link
Contributor

@katjaweigel katjaweigel commented Jun 9, 2023

Description

Removing fx_variables: null from
ipccwg1ar5ch9/recipe_flato13ipcc_figures_938_941_cmip3.yml
ipccwg1ar5ch9/recipe_weigel21gmd_figures_13_16.yml
ipccwg1ar5ch9/recipe_flato13ipcc_figures_938_941_cmip6.yml
to adapt to recent changes in the ESMValCore.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

Updated recipe


To help with the number of pull requests:

@katjaweigel
Copy link
Contributor Author

Tests still running, therefore draft PR.
For ipccwg1ar5ch9/recipe_weigel21gmd_figures_13_16.yml it works to just remove the lines, but there are small changes. fx_variables: null was added, because not all fx files were found, therefore the changed version should be the better one, but I need to wait if also the other recipes now run without the lines or if I need to explicitly remove/set supplementary_variables for some data sets.

@katjaweigel
Copy link
Contributor Author

I tested all recipes and there are only small changes if at all, so it should be ok to remove fx_variables: null

@katjaweigel katjaweigel marked this pull request as ready for review June 12, 2023 13:47
@remi-kazeroni remi-kazeroni added this to the v2.9.0 milestone Jun 14, 2023
Copy link
Contributor

@remi-kazeroni remi-kazeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, @katjaweigel! Changes look fine to me and recipes run successfully. This PR is ready to be merged 👍

@schlunma schlunma merged commit cf517e1 into main Jun 14, 2023
@schlunma schlunma deleted the remove_fx_variable_from_ipccwg1ar5ch9_recipes branch June 14, 2023 09:29
ehogan added a commit that referenced this pull request Jun 26, 2023
…old_and_clone_task_rtw

* recipe_test_workflow_prototype: (199 commits)
  #3169: Upgrade the RTW to work with ESMValTool v2.8.0
  [Condalock] Update Linux condalock file (#3237)
  Modified links to the tutorial (#3236)
  Add ESMValCore release `v2.8.1` into the documentation (#3235)
  Generate climatology on the fly for AutoAssess soil moisture (#3197)
  New recipe and diagnostic for Arctic-midlatitude research (#3021)
  Fixed pandas diagnostics for pandas>=2.0.0 (#3209)
  Update obs4MIPs dataset to the current naming scheme in recipe_smpi.yml (#2991)
  Add variable long names to provenance record in monitoring diagnostics (#3222)
  Extension of NASA MERRA2 CMORizer (cl, cli, clivi, clw, clwvi) (#3167)
  Remove "fx_variable" from recipe_wenzel14jgr.yml (#3212)
  [Condalock] Update Linux condalock file (#3217)
  Add Seaborn diagnostic (#3155)
  Remove fx_variables from ipccwg1ar5ch9 recipes (#3215)
  Remove "fx_variable" from recipe_tebaldi21esd.yml (#3211)
  Update recipe_impact.yml to work with newer versions of `pandas` (#3220)
  Use ESMValCore v2.9.0 release candidates (#3219)
  [Github Actions ] Check if python minor version changed after Julia install in development installation test (#3213)
  New plot_type 1d_profile in monitor  (#3178)
  Add support for using a dask distributed scheduler (#3151)
  ...
jvegreg pushed a commit that referenced this pull request Jan 14, 2024
Co-authored-by: Rémi Kazeroni <remi.kazeroni@dlr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants