-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file #3307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: valeriupredoi <valeriupredoi@users.noreply.github.com>
valeriupredoi
changed the title
[condalock] update conda lock creation Github Action workflow
[condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file
Jul 24, 2023
@bouweandela since you back from 🏖️ maybe you could give this a review pls bud - our lockfile is getting 👴 |
bouweandela
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍻
tak @bouweandela 🍺 |
ehogan
added a commit
that referenced
this pull request
Aug 30, 2023
…_RTW * recipe_test_workflow_prototype: (237 commits) Add version to dataset in python example recipe to avoid "Unknown file format" issue on JASMIN (#3322) CMORizer for NASA MERRA reanalysis (#3039) Add `OBS-maintainers` team to documentation on OBS data maintenance and CMORizer reviews (#3335) Fixed provenance tracking for NCL multipanel PNGs (#3332) Cmorizer for NOAA-CIRES-20CR v3 reanalysis (clt, clwvi, hus, prw, rlut, rlutcs, rsut, rsutcs) (#3137) [Condalock] Update Linux condalock file (#3321) Slight refactoring of diag `galytska23/select_variables_for_tigramite.py` for generality and portability (for Changelog v2.10: authors: @valeriupredoi and @egalytska) (#3298) Removed recipe_carvalhais14nat from list of broken recipes (#3319) add Romain Beucher to CITATION as contributor (#3318) update `mamba` version in readthedocs configuration docs builds (#3310) [Github Actions] Compress all bash shell setters into one default option per workflow (#3315) [condalock] update conda lock creation Github Action workflow and ship updated (bot-generated) conda-lock file (#3307) Allow NCL unit conversion `kg s-1` -> `GtC y-1` (#3300) Add list of failing recipes for v2.9.0 release (#3294) Update diag_shapeselect.py to work with shapely v2 (#3283) Update release schedule after release of v2.9.0 (#3289) Add merge instructions to release instructions (#3292) Made sklearn test backwards-compatible with sklearn < 1.3 (#3285) Add release notes for v2.9 (#3266) Add release notes for v2.9 (#3266) ...
jvegreg
pushed a commit
that referenced
this pull request
Jan 14, 2024
…p updated (bot-generated) conda-lock file (#3307) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: valeriupredoi <valeriupredoi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The conda-lock file creation currently fails because our conda/mamba combo is too old to handle installing the updated version of
conda-lock
(as it comes shipped with setup-miniconda@v2, despite a forced conda base update); this solves the problem by forcing a very new mamba, which, in turn, updates conda too; this has been done in ESMValCore in ESMValGroup/ESMValCore#2136In addition to this, I have now set the shell at the very top of the workflow file, and doing that just once, w/o the need to specify the shell for every run step. As described in #3279 (still to be done for the other workflows, this is just for the conda-lock flow).
This was tested in this test run that correctly produced a bot PR #3309 that I will now merge here so we ship this PR with an updated conda lock file too (verified and looked at by yours truly).
conda-lock=2.1.0
fails to build lockfile #3290Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.