Continue on cert errors #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually it works. This feature is disabled by default, but the user can turn it on by setting "continue_on_cert_errrors=true" in the download section of the configuration file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for pull request 145, issued in May 2020. It does the same thing, but request 145 was compatible with the master branch in May, and this is compatible with the current master branch. If the master branch changes again, I will not redo this request.
The purpose of this patch is to allow use of Synda when a identity server is down, unable to renew certificates; but the existing certificates are still valid. In this case, Synda can and should continue to work normally - with rare exceptions when a certificate has actually expired.
If the user does nothing, then there is no change from the present behavior of Synda.
But if the user sets "continue_on_cert_errors=true" in the download section of his configuration file, then certificate errors will be essentially ignored. Specifically, when sddmdefault.transfers_begin() encounters an exception while renewing a certificate, then it will simply continue.
This small change is essential to production-scale operation of Synda for replication, and prevents an occasional confusing error for all uses of Synda. The reason for requiring a setting in the configuration file is that there is a certain small risk, and the user should be aware of it.