-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzz testing with google/oss-fuzz #802
Comments
@jwellbelove friendly ping. I'm about to take another pass over this, but I'm a little puzzled by what the current state is. Specifically it looks like you changed the source branch for #801 from main/master to '801-fuzz-Add-fuzz-harnesses-for-string-crc-apis' and then merged it into that branch. Is there something that you wanted changed in the original PR before it made it into the main branch? I guess I feel like I'm missing something important as I've not seen a workflow similar to this. Once it's merged into the main branch it'll be a relatively minimal amount of effort for me to integrate this into oss-fuzz, if that's something that you are still interested in. |
I like to keep pull requests and issues on their own branch until I am happy that they are ready to merge into 'master'. The branch I change them to is based on master. |
Ah ok understood. I'll quickly draft up an integration with oss-fuzz. Then if/when you have the bandwidth for it feel free to ping me and I'll go over #801 with you and answer any questions and make changes as needed. |
I derived this rule from ETLCPP#802 (comment)
* Update README.md * Apply instructions for pull requests from Slack to new CONTRIBUTING guideline file. I copied the [message in Slack](https://etlcpp.slack.com/archives/C7SJ45VFB/p1729596737002559) from @jwellbelove into a new file for [contributing guidelines](https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors). This way a starting point for potential contributors is delivered next to the source code. * Added hint for the starting point for contributing commits. I derived this rule from #802 (comment) --------- Co-authored-by: John Wellbelove <jwellbelove@users.noreply.github.com>
* Update README.md * Apply instructions for pull requests from Slack to new CONTRIBUTING guideline file. I copied the [message in Slack](https://etlcpp.slack.com/archives/C7SJ45VFB/p1729596737002559) from @jwellbelove into a new file for [contributing guidelines](https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors). This way a starting point for potential contributors is delivered next to the source code. * Added hint for the starting point for contributing commits. I derived this rule from #802 (comment) --------- Co-authored-by: John Wellbelove <jwellbelove@users.noreply.github.com>
* Update README.md * Apply instructions for pull requests from Slack to new CONTRIBUTING guideline file. I copied the [message in Slack](https://etlcpp.slack.com/archives/C7SJ45VFB/p1729596737002559) from @jwellbelove into a new file for [contributing guidelines](https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/setting-guidelines-for-repository-contributors). This way a starting point for potential contributors is delivered next to the source code. * Added hint for the starting point for contributing commits. I derived this rule from #802 (comment) --------- Co-authored-by: John Wellbelove <jwellbelove@users.noreply.github.com>
Hey ETL Team,
I hope this message finds you well. I've been following along with ETL for some time now, and have integrated it into a number of projects. I'd like to suggest and champion an effort to set up some basic fuzz-testing and combine it with google/oss-fuzz for continuous fuzzing. I'm fully aware that you are very busy people and I don't want to overload your review/maintenance capacity by introducing too many new ideas. Is this a bad time to discuss potential security/reliability improvements?
If your not familiar with fuzzing or oss-fuzz I've included a few brief notes below.
Benefits of Fuzz-Testing
Google/oss-fuzz for Continuous Fuzzing
I’d be more than happy to lead the effort in integrating fuzz testing with ETL and assist in any way required.
As a proof of concept I created a couple of super simple fuzz harnesses for the for the some of the hashers and also string functions in #801.
The text was updated successfully, but these errors were encountered: