Fixed memory.h: mem_copy, mem_move, mem_compare for pointers to const #1005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
master
to
pull-request/#1005-mem_copy-mem_move-mem_compare-for-pointers-to-const
jwellbelove
merged commit 599931f
into
ETLCPP:pull-request/#1005-mem_copy-mem_move-mem_compare-for-pointers-to-const
63 checks passed
jwellbelove
added a commit
that referenced
this pull request
Jan 31, 2025
…inters-to-const' into development # Conflicts: # .gitignore
jwellbelove
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mem_copy() etc. get the constness wrong: "const TPointer" is not a pointer to const data, as intended.
The additional tests illustrate the problem by failing to compile in current ETL.
The change to memory.h fixes it.