Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused functions from evsev2g #1012

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MarzellT
Copy link
Member

@MarzellT MarzellT commented Jan 20, 2025

Describe your changes

During the team week we noticed a couple of functions being unused. We removed those with this pull request.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

Copy link
Contributor

@SebaLukas SebaLukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Lint CI jobs failed.

@SebaLukas SebaLukas requested review from barsnick and FaHaGit January 20, 2025 09:38
@SebaLukas
Copy link
Contributor

@barsnick @FaHaGit I think this is okay, if these unused functions will be removed?

Copy link
Contributor

@james-ctc james-ctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@SebaLukas SebaLukas changed the title remove unused functions from evsev2g Remove unused functions from evsev2g Feb 4, 2025
@SebaLukas SebaLukas added the post-release Tag that this PR should not go into the current merge window for the upcoming release label Feb 4, 2025
@MarzellT MarzellT force-pushed the feat/remove-unused-functions-from-evsev2g branch from e34c842 to 39678c0 Compare February 4, 2025 09:31
MarzellT and others added 4 commits February 11, 2025 08:22
Signed-off-by: MarzellT <tobias.marzell@pionix.de>
Signed-off-by: Anton Kadelbach <anton.kadelbach@pionix.de>
Signed-off-by: Anton Kadelbach <anton.kadelbach@pionix.de>
Signed-off-by: MarzellT <tobias.marzell@pionix.de>
@MarzellT MarzellT force-pushed the feat/remove-unused-functions-from-evsev2g branch from 39678c0 to 0637f59 Compare February 11, 2025 07:27
@MarzellT MarzellT marked this pull request as draft February 11, 2025 07:32
Signed-off-by: MarzellT <tobias.marzell@pionix.de>
@MarzellT MarzellT marked this pull request as ready for review February 11, 2025 08:17
@barsnick
Copy link
Contributor

Checking this now.

I also have another removal of an unused variable in my stash:

diff --git a/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp b/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp
index a1ca7637..966fcf9c 100644
--- a/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp
+++ b/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp
@@ -54,8 +54,6 @@ void ISO15118_chargerImpl::init() {
 
     v2g_ctx->network_read_timeout_tls = mod->config.tls_timeout;
 
-    v2g_ctx->certs_path = mod->info.paths.etc / CERTS_SUB_DIR;
-
     /* Configure if the contract certificate chain should be verified locally */
     v2g_ctx->session.verify_contract_cert_chain = mod->config.verify_contract_cert_chain;
 
diff --git a/modules/EvseV2G/v2g.hpp b/modules/EvseV2G/v2g.hpp
index 9b69a097..718d4b91 100644
--- a/modules/EvseV2G/v2g.hpp
+++ b/modules/EvseV2G/v2g.hpp
@@ -198,7 +198,6 @@ struct v2g_context {
     struct sockaddr_in6* local_tcp_addr;
     struct sockaddr_in6* local_tls_addr;
 
-    std::string certs_path;
     std::string tls_key_logging_path;
 
     uint32_t network_read_timeout;     /* in milli seconds */

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
post-release Tag that this PR should not go into the current merge window for the upcoming release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants