-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused functions from evsev2g #1012
Open
MarzellT
wants to merge
5
commits into
main
Choose a base branch
from
feat/remove-unused-functions-from-evsev2g
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebaLukas
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Lint CI jobs failed.
james-ctc
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
e34c842
to
39678c0
Compare
Signed-off-by: MarzellT <tobias.marzell@pionix.de>
Signed-off-by: Anton Kadelbach <anton.kadelbach@pionix.de>
Signed-off-by: Anton Kadelbach <anton.kadelbach@pionix.de>
Signed-off-by: MarzellT <tobias.marzell@pionix.de>
39678c0
to
0637f59
Compare
Signed-off-by: MarzellT <tobias.marzell@pionix.de>
Checking this now. I also have another removal of an unused variable in my stash: diff --git a/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp b/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp
index a1ca7637..966fcf9c 100644
--- a/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp
+++ b/modules/EvseV2G/charger/ISO15118_chargerImpl.cpp
@@ -54,8 +54,6 @@ void ISO15118_chargerImpl::init() {
v2g_ctx->network_read_timeout_tls = mod->config.tls_timeout;
- v2g_ctx->certs_path = mod->info.paths.etc / CERTS_SUB_DIR;
-
/* Configure if the contract certificate chain should be verified locally */
v2g_ctx->session.verify_contract_cert_chain = mod->config.verify_contract_cert_chain;
diff --git a/modules/EvseV2G/v2g.hpp b/modules/EvseV2G/v2g.hpp
index 9b69a097..718d4b91 100644
--- a/modules/EvseV2G/v2g.hpp
+++ b/modules/EvseV2G/v2g.hpp
@@ -198,7 +198,6 @@ struct v2g_context {
struct sockaddr_in6* local_tcp_addr;
struct sockaddr_in6* local_tls_addr;
- std::string certs_path;
std::string tls_key_logging_path;
uint32_t network_read_timeout; /* in milli seconds */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
post-release
Tag that this PR should not go into the current merge window for the upcoming release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
During the team week we noticed a couple of functions being unused. We removed those with this pull request.
Issue ticket number and link
Checklist before requesting a review