Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in script #1005

Merged
merged 1 commit into from
Sep 27, 2022
Merged

fix: typos in script #1005

merged 1 commit into from
Sep 27, 2022

Conversation

Westlad
Copy link
Contributor

@Westlad Westlad commented Sep 27, 2022

What does this implement/fix? Explain your changes.

Fixes a bug in the setup script which prevents it running on an M1 Mac.

Does this close any currently open issues?

Any relevant logs, error output, etc?

Any other comments?

It's essentially a small typo

@Westlad Westlad added the Bug label Sep 27, 2022
Copy link
Contributor

@daveroga daveroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daveroga daveroga added the One more approval needed One reviewer has approved this PR but another is needed label Sep 27, 2022
Copy link

@velkoskis velkoskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siosw siosw merged commit 7941182 into master Sep 27, 2022
@siosw siosw deleted the westlad/setup-fix branch September 27, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug One more approval needed One reviewer has approved this PR but another is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants