refactor cli folder #1428
Open
refactor cli folder #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
requested changes
May 19, 2023
common-files/constants/sdk.mjs
Outdated
| @@ -4,13 +4,6 @@ export const TOKEN_TYPE = { | |||
| ERC1155: 'ERC1155', | |||
| }; | |||
|
|
|||
| export const TX_TYPES = { | |||
There was a problem hiding this comment.
Can you rename this file nf3.mjs? Use of sdk.mjs is confusing as there is no sdk in this repo and that makes it hard to know what uses these constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR deletes
clifolder and place its common used files incommon-filesfolders and refactor codes accordinglyDoes this close any currently open issues?
What commands can I run to test the change?
This PR merge will definitely break other PR in the list, if their code change touches
clifolderAny other comments?