-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
daveroga/rationalize configs #398
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep web3 node url out of repo code. PR #334 proposes a way to do it. I suggest once it is approved, just reuse it
PR already solved but e2e test failing due to issue #427 that should be solved first. |
ganache-test seems to fail sometimes. Forced modify a file to test it again. |
This seems to add 263 commits in total. Most of which are commits that already exist in the master. Could you revert this to just the commits from this PR please? |
c7dba3c
to
b55fd39
Compare
b55fd39
to
5e9e4c7
Compare
Wrong commits added after rebase were reverted and rebase again from master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but just mind some tests are being removed by #490
🎉 This PR is included in version 1.16.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
…basis ⚔ fix: fixing conflicts with #398 and moving eslint rule to a per-file basis ⚔
Fixes issue #355 .
The configuration for this application is becoming fragmented. It now exists in:
Probably it is sensible just to use one of these.
Steps to solve this: