fix offchain connection and tests #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
requested review from
IlyasRidhuan,
signorecello,
ChaitanyaKonda and
druiz0992
signorecello
approved these changes
May 9, 2022
ChaitanyaKonda
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offchain transfer tests in
erc20.test.mjswere evergreen;clientwas unable to connect tooptimist's/proposer/offchain-transactionendpoint because nooptimistAPI URL was provided by the test harness toclient. This caused a connection error whenclienttried to connect. However the error was thrown and caught inside an async.forEachloop insidetransfer.mjsand so did not propagate back to the test harness - a double whammy.This PR fixes both problems by providing a correct URL for
optimist(NB: this has to be the URL as seen from inside theclientcontainer), and by propagating any error correctly by turning the.forEachinto a.mapthen awaiting completion of the calls tooptimist.