Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix more syncing issues #650

Merged
merged 11 commits into from
May 11, 2022
Merged

fix more syncing issues #650

merged 11 commits into from
May 11, 2022

Conversation

Westlad
Copy link
Contributor

@Westlad Westlad commented May 10, 2022

This fixes a number of corner-case syncing issues:

  1. When optimist synchronises, it's possible that new transactions could come in. These were ignored. To fix this, we subscribe to events from the L1 block one after syncing ends, rather than from the current block, which may be ahead by some distance.
  2. offchain transactions are now queued along with onchain ones. This gives a consistent way of managing them during synchronisation (and more generally).
  3. When syncing, the block and transaction queues are paused. They will still accept new transactions but these are not processed until syncing is finished.

@Westlad Westlad merged commit b7fbc16 into master May 11, 2022
@Westlad Westlad deleted the westlad/sync-gap-fix branch May 11, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants