Adds some functionality and fixes to wallet #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveroga
approved these changes
May 13, 2022
imagobea
approved these changes
May 13, 2022
There was a problem hiding this comment.
Just leaving comments for future iterations. These are certainly nice additions, thank you.
Syncing indicator- We could improve this by taking timber into account, which is what takes longer (the indicator was green, but I was still receiving blocks)Chain detection- Works fine but Metamask is always difficult (dialogs were not 'popping up' and that was conflicting with the sync indicator...)L2 Bridge page validations- I would disable theTransferbutton altogether (looks like you can carry on with the tx). Also, we should expand validations for balance and0value.
daveroga
reviewed
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing indicator for Nightfall to show when the wallet has completely synced the circuits and chain state
Chain detection, wallet will check to see the user is currently connected to Ethereum main net and disallow deposits otherwise.
User inputs in deposit and withdraw - raises a warning if the amounts are greater than the current restrictions.
Updated the txinfo modal that pops up when clicking on a transaction in the 'transactionPage'