Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing audit Issue Y #765

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Addressing audit Issue Y #765

merged 2 commits into from
Jun 22, 2022

Conversation

IlyasRidhuan
Copy link
Contributor

@IlyasRidhuan IlyasRidhuan commented Jun 17, 2022 •
edited
Loading

This PR closes #147 adds some safe modulo operations where they have been missing.

druiz0992
druiz0992 suggested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@druiz0992 druiz0992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the routines in common-files/utils/crypto/number-theory.mjs seem to have the same problem as the ones you fixed here. Can you take a look and comment?

@druiz0992 druiz0992 added the One more approval needed One reviewer has approved this PR but another is needed label Jun 22, 2022
daveroga
daveroga approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@daveroga daveroga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daveroga daveroga removed the One more approval needed One reviewer has approved this PR but another is needed label Jun 22, 2022
@daveroga daveroga merged commit 62a007d into master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveroga daveroga daveroga approved these changes

@druiz0992 druiz0992 druiz0992 approved these changes

@Westlad Westlad Awaiting requested review from Westlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IlyasRidhuan @druiz0992 @daveroga