Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pino logger #851

Merged
merged 22 commits into from
Aug 9, 2022
Merged

Enable pino logger #851

merged 22 commits into from
Aug 9, 2022

Conversation

druiz0992
Copy link
Contributor

@druiz0992 druiz0992 commented Aug 4, 2022

Fixes #846

Use pino logger so that its easier to export logs to data dog monitoring services

This is the expected log output for production environments, in JSON format:
{"level":"info","time": "2022-08-08T20:25:08.112Z","msg":"Received request to /vk"}

For the non-production envs the logs continue with the same format, with a slightly difference, the timestamp:
[2022-08-09 08:52:35.298] WARN: Attempted to replay existing transaction. This is expected while syncing

@druiz0992 druiz0992 requested a review from israelboudoux August 4, 2022 19:35
Copy link
Contributor

@israelboudoux israelboudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@druiz0992 druiz0992 added the One more approval needed One reviewer has approved this PR but another is needed label Aug 5, 2022
@druiz0992 druiz0992 changed the title Change to pino logger Enable pino logger Aug 5, 2022
@druiz0992 druiz0992 removed Merge conflict One more approval needed One reviewer has approved this PR but another is needed labels Aug 5, 2022
@israelboudoux israelboudoux added the DNM Do not merge label Aug 5, 2022
@israelboudoux
Copy link
Contributor

I've added a DNM because I'll do a couple of tests before merging.

@israelboudoux israelboudoux removed the DNM Do not merge label Aug 5, 2022
@druiz0992 druiz0992 merged commit 2fa3892 into master Aug 9, 2022
@druiz0992 druiz0992 deleted the david/logger-pino branch August 9, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring logs #1
3 participants