-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving GitHub Actions tests #886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @israelboudoux, nice contribution towards a more organised code base!! 💪
I'm just going to suggest a few more changes which you can apply if you agree. It's about script commands on the package.json (below).
I think that might be worth to rename as well some of the jobs on the GitHub workflows. Eg use always test
in front of jobs that are actually running tests.
Last but not least, is it possible that we are not running the rollback-resync
test?! 🤔
Cheers!!
"test":
"test-e2e-protocol"
"test-gas" >> "test-e2e-gas"
"test-circuits" >> "test-e2e-circuits"
"test-e2e-tokens"
"test-erc20-tokens" >> "test-e2e-tokens-erc20" OR "test-tokens-erc20"
"test-erc721-tokens" (like erc20)
"test-erc1155-tokens" (like erc20)
"test-erc20-cli" >> "test-client-erc20" - The word `cli` typically refers to old sdk (cli/lib)
"test-adversary"
"test-all-adversary" >> "test-adversary-all"
"test-general-stuff" >> "test-others" (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds missing tests to Github Actions pipeline: