constants and config refactor #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signorecello
suggested changes
Sep 6, 2022
ChaitanyaKonda
approved these changes
Sep 6, 2022
signorecello
approved these changes
Sep 7, 2022
RogerTaule
suggested changes
Sep 9, 2022
There was a problem hiding this comment.
The following constants are unused: BLOCK_PROPOSED_EVENT_NAME, ZKP_KEY_LENGTH and NODE_HASHLENGTH.
The following config variables are unused: NULLIFIER_COLLECTION, WALLETS_COLLECTION, PEERS_COLLECTION, PROOF_QUEUE and ELLIGATOR2.
Could you please remove them? Thanks!
LijuJoseJJ
force-pushed
the
liju.jose/fixes-890
branch
from
33247f4 to
28d09fa
Compare
RogerTaule
suggested changes
Sep 9, 2022
LijuJoseJJ
force-pushed
the
liju.jose/fixes-890
branch
from
7bd9a27 to
fe474d9
Compare
RogerTaule
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #890