David/ping pong update #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signorecello
approved these changes
Sep 13, 2022
| const stateContractInstance = await waitForContract(STATE_CONTRACT_NAME); | ||
| const currentProposer = await stateContractInstance.methods.getCurrentProposer().call(); | ||
| stateContractInstance = await waitForContract(STATE_CONTRACT_NAME); | ||
| currentProposer = await stateContractInstance.methods.getCurrentProposer().call(); |
There was a problem hiding this comment.
Hey @druiz0992, why do not reuse the same instances from the lines 60-61?
There was a problem hiding this comment.
You’re right, thanks
israelboudoux
approved these changes
Sep 13, 2022
apps/challenger/src/app.mjs
Outdated
| @@ -53,6 +33,8 @@ app.use( | |||
| ); | |||
|
|
|||
| app.get('/healthcheck', (req, res) => res.sendStatus(200)); | |||
| if (!CHALLENGER_PORT) throw new Error('Please specify a challenger port'); | |||
There was a problem hiding this comment.
Will this exception ever happen? On line 12 we specify a fallback value of 8192 in case the port is not defined. Either we should get rid of the default value from line 12, or remove this condition.
There was a problem hiding this comment.
you're right. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes required to make #823 work in deployment:
apps/challengerto be consistent withapp/proposerregisterChallengerfromapps/challenger/src/challenger.mjsas its not needed anymorelog(environment)from apps as it reveals private informationMULTISIG_APPROVERSin config