Containerizing proposer #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
druiz0992
suggested changes
Sep 13, 2022
| @@ -0,0 +1,2 @@ | |||
| #! /bin/bash | |||
| docker-compose -f docker-compose.apps.yml up proposer | |||
There was a problem hiding this comment.
Hey @signorecello, what about the Challenger?
There was a problem hiding this comment.
i think we can add a separate PR for challenger. Proposer is urgent
druiz0992
approved these changes
Sep 13, 2022
israelboudoux
approved these changes
Sep 13, 2022
druiz0992
reviewed
Sep 13, 2022
docker-compose.apps.yml
Outdated
| context: . | ||
| ports: | ||
| # to use with postman and etc | ||
| - 8083:8080 |
There was a problem hiding this comment.
There seems to be a port inconsistency with app.mjs where port is 8092
druiz0992
suggested changes
Sep 13, 2022
|
it would be quite useful to add a proposer test that launches containers, checks healthcheck, and exits. This way, we always guarantee proposer is working |
|
Hey I couldn't agree more, but I think it should be part of another ticket, as some team members need this container to work ASAP |
|
Added #934 and will work on that ASAP |
druiz0992
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes that the proposer (pun intended) is containerized so all its paths match with our deployment repo. A new script is born that simply runs this new
docker-composefile