Test administrator features with multisig #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveroga
force-pushed
the
daveroga/test-admin
branch
from
feb1924 to
bba3237
Compare
druiz0992
reviewed
Sep 22, 2022
daveroga
force-pushed
the
daveroga/test-admin
branch
from
bba3237 to
5d860ea
Compare
Yes. Changed this with the |
druiz0992
approved these changes
Sep 24, 2022
druiz0992
added
the
One more approval needed
daveroga
force-pushed
the
daveroga/test-admin
branch
from
ab89dea to
41bbccb
Compare
daveroga
force-pushed
the
daveroga/test-admin
branch
from
41bbccb to
adc1300
Compare
israelboudoux
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Hey @daveroga, I have a question: are the files multisig.mjs and nightfall-multisig.mjs supposed to be under the test folder?
This will be moved to the SDK to the role of administrator. We have to decide when to do it. Then we will refactor this and nightfall-administrator with the SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fix: #963 . Test multisig functionality.
Fix some issue with the nonce of the multisig in
nightfall-administrator.Test with
npm run test-administratorDoes this close any currently open issues?
Yes #963.
Any relevant logs, error output, etc?
Any other comments?