fix: setup contracts script #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveroga
added
the
One more approval needed
druiz0992
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Fix: #994
Deployer is failing with an error at the end. Also
Statecontract is not transferring ownership to multisig.I have divided for readability the contracts in 2 groups.
contractsStatethat will callsetStateContract. (Proposers, Shield, Challenges)contractsOwnablesthat will calltransferOwnership. (Proposers, Shield, Challenges, State)Does this close any currently open issues?
Yes. #994
Any relevant logs, error output, etc?
Any other comments?