Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #218, caused by new libclf versions #221

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fixed issue #218, caused by new libclf versions #221

merged 1 commit into from
Oct 25, 2023

Conversation

MolassesLover
Copy link
Contributor

This pull request aims to fix issue #218 by replacing SpriteTransparency with PlayerVisibility, and ChangeEncounterRate with ChangeEncounterSteps, matching changes introduced to libclf since the last commit.

> **Note**: This commit message is written in Markdown for the sake of
clean documentation.

This commit fixes issue
[#218](#218)
which was a combination of compilation errors starting from libclf
commit `b6a280bc57b31fd3ebad3b55b5ae75a5bec46a61`. Another error
appeared as well, starting from `2a2e0d3900bfd11826626a8b28c7a6bf9bcb410c`.
@Ghabry
Copy link
Member

Ghabry commented Oct 23, 2023

Jenkins: Test this please

Thanks. To explain the lack of updates here: I'm currently working on a large contribution to the editor in private with the goal to move it to a usable state more quickly. When this is ready I'll submit the code.

@MolassesLover
Copy link
Contributor Author

Thanks. To explain the lack of updates here: I'm currently working on a large contribution to the editor in private with the goal to move it to a usable state more quickly. When this is ready I'll submit the code.

No worries at all, please don't feel rushed! Thank you for looking into my pull request, I hope you're having a lovely day. <3

@Ghabry
Copy link
Member

Ghabry commented Oct 24, 2023

Jenkins: test this please

@Ghabry Ghabry merged commit f54d040 into EasyRPG:master Oct 25, 2023
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants