Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update key descwiptions #3107

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Update key descwiptions #3107

merged 3 commits into from
Nov 2, 2023

Conversation

MikuChan03
Copy link
Contributor

Hi~~

Watakushi (said when sewious), doesn't want to be a bothew,
but watakushi believes that the wwong key descwiptions could make usews dizzy.

screenshot_1

So hewe's a tiny PW that changes what I said in #3104. While at it, we also wemove the x3 and x10
pawt in the fast fowward descwiptions, because that's configuwable now

Remove the duplicate page up key entries.
Also remove the x3 and x10 parts for fast forward,
since that's configurable now.
@jetrotal
Copy link
Contributor

Heyo!

Maybe renaming FF buttons to
"Fast Foward A" and "Fast Foward B" could help, since nowdays it's possible to make the second slower than the first.

Not necessary, but I wonder if it would be possible to concat the speed value from the FF variables to help showing what they do?

Thanks again!

@Mimigris Mimigris added the Settings All about customizable features, storing and applying them label Sep 30, 2023
@MikuChan03
Copy link
Contributor Author

@jetrotal sure, will do ^.^
Though if we weally wanted to go all out, we would make the cweation of these
speed modifiews and the keybindings of them dynamic, meaning the usew could have
like 10 diffewent speed modifiews?

@jetrotal
Copy link
Contributor

jetrotal commented Sep 30, 2023

hm... unlimited speed modifiers? I wonder...

Though, there are games that uses a lot of buttons already, and we plan to reserve more shortcuts to when we add support to multiplayer features from https://github.com/monokotech/EasyRPG-Multiplayer-Native

Maybe 2 is already a good amount 🤔

@Mimigris
Copy link

If you want my opinion, 2 buttons to edit the speed is likely good enough for now, it could still be changed later in any case if there's a request. 👍

@MikuChan03
Copy link
Contributor Author

MikuChan03 commented Oct 1, 2023

KK,

watashi did all that good stuff! Meaning watashi changed not only the usew facing descwiptions of fast fowwawd,
but also the souwce code. Only the actual Enums wewe too scawy fow watashi, because they awe being used in platfowms
as well.

screenshot_0

Made it so that the descwiption is dynamically updated too:

screenshot_1

Evewything is happening so much 🤪

@jetrotal
Copy link
Contributor

jetrotal commented Oct 1, 2023

Thanks for the help, very sugoi and very kakkoii.

@Ghabry
Copy link
Member

Ghabry commented Oct 1, 2023

Jenkins: test this please

@MikuChan03
Copy link
Contributor Author

MikuChan03 commented Oct 1, 2023

Sowwy, fowgot to exchange a vawiable name in platfowms. Will do so wight away.

@MikuChan03
Copy link
Contributor Author

Jenkins: test this please

@Ghabry
Copy link
Member

Ghabry commented Oct 1, 2023

Jenkins: test this please

Sowwy, only admins can do this

@Ghabry Ghabry added this to the 0.8.1 milestone Oct 1, 2023
@nbittich
Copy link

nbittich commented Oct 2, 2023

you should have said pweease jenukinsu san

@fdelapena fdelapena requested a review from Ghabry October 16, 2023 18:48
@Ghabry
Copy link
Member

Ghabry commented Oct 21, 2023

Imo this looks fine. I just want to do a chance on the Android Java Ui side so it reads/writes the value directly through the INI like we already do for some other settings.

Will do this next week, I don't have all the Android dev env crap setup on this system.

@Ghabry
Copy link
Member

Ghabry commented Nov 2, 2023

Currently not motivated to do the Android stuff. Merging this for now and fixing that minor problem later

@Ghabry Ghabry merged commit f686945 into EasyRPG:master Nov 2, 2023
12 checks passed
@TruncatedDinoSour
Copy link

a

@DeveloLongScript
Copy link

github in a nutshell

trolls

@EasyRPG EasyRPG locked as off-topic and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Settings All about customizable features, storing and applying them
Development

Successfully merging this pull request may close these issues.

8 participants