New command "Wait for Single Movement" #3221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on work of @jetrotal
…e state. Is required to prevent that the variable changes across waits and causes issues.
Ghabry
added
Event/Interpreter
EasyRPG
fdelapena
approved these changes
Jul 13, 2024
|
this looks good, but is it ok to aprove it while it fails it checks |
|
okay lets continue a bit after a long break... This command is just great. Tested it now in detail and it works after merging EasyRPG/liblcf#478 Tested with a move failure count of 200 which correctly terminates and writes a 0 in the target variable. Also tested saving and loading. Is correctly restored. Here is a test map that is compatible with "Maniac TestGame" recently merged (but should be its own "TestGame" for EasyRpg exclusive stuff). That work isn't finished so just the map for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally by @jetrotal
Redid the stuck check.
Also made the "waiting" similiar to how other events do it: E.g. "Wait for Key" will store all the keys it wants and no reread them from the event everytime. This is necessary because the values of variables can change. Storing them on first call avoids this issue.