Maniacs Feature - Pixel scrolling support for CommandPanScreen #3245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing debug code, polishing code + Added support for .relative and .centered options for Absolute Pixel pan. Needed to bitmask parameter[4] in order to check for those. = Renamed a few commands = Added comments for some functions - Removed debug code Adjusting the speed formula Now it works very well, even has differnet speeds for both H and V. However since Maniac internally uses doubles for screen panning, we might have to do some more work... Revert "Adjusting the speed formula" This reverts commit 52fa842. Adjusting the speed formula Again Now everything works as it should. Time to use doubles for everything Corrected interpolation, and proper scrolling speed Correct formula for absolute positioning Absolute Cam Panning now works Changed some naming scheme First things to do for Pixel Scrolling Adding support for commands However scrolling is a bit jaggy compared to ManiacPatch
ToolMan2k
changed the title
27 tasks
fdelapena
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows to pan the camera using X and Y coordinates.
Note:
There seems to be a bug on Maniac, when you have a looping map, you scroll up-left into negative coordinates, and you try to pan back to the center, more often than not it will keep panning diagonally indefinitely. Luckily EasyRPG doesn't have this issue, but for parity reasons we could try to reimplement that.
Sister request for EasyRPG/liblcf#482