Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "Think Java: How to Think Like a Computer Scientist" #5297

Merged
merged 1 commit into from
Feb 16, 2021

Conversation

tunggnu
Copy link
Contributor

@tunggnu tunggnu commented Feb 15, 2021

What does this PR do?

  • Add the 2nd Edition.
  • Update the 1st Edition:
    • Replace the obsolete link with the current link.
    • Add the Interactive version link.

For resources

Why is this valuable (or not)?

It is a well-known book for beginners.

How do we know it's really free?

1st Edition: Creative Commons Attribution-NonCommercial-ShareAlike 3.0 Unported License
2nd Edition: Creative Commons Attribution-NonCommercial-ShareAlike 4.0 International License

Checklist:

  • Read our contributing guidelines
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction)

Followup

  • Check the output of Travis-CI for linter errors!

* Add the 2nd Edition.
* Update the 1st Edition:
  * Replace the obsolete link with the current link.
  * Add the Interactive version link.
@eshellman
Copy link
Collaborator

Looks like you have an extra space before the 1st edition link - is that intended?

@tunggnu
Copy link
Contributor Author

tunggnu commented Feb 16, 2021

Yes, that is. It's not an extra space. They are two spaces to make the 1st edition a sub-item of the 2nd edition. I follow the CONTRIBUTING Guidelines which mentioned "see Issue #2353 to contribute to the discussion on formatting."

You can see some existing examples in the English books page:

@eshellman
Copy link
Collaborator

Thanks for checking!

@eshellman eshellman merged commit f099038 into EbookFoundation:master Feb 16, 2021
@tunggnu tunggnu deleted the thinkjava branch February 16, 2021 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants