Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHUX-690] Make metroline footer cta mobile friendly #2005

Merged
merged 6 commits into from
Jul 10, 2024
Merged

[CHUX-690] Make metroline footer cta mobile friendly #2005

merged 6 commits into from
Jul 10, 2024

Conversation

stavros-tomas
Copy link
Collaborator

@stavros-tomas stavros-tomas commented Jul 8, 2024 •
edited
Loading

In this PR

  • Removing the max-width limitation of button components.
  • Making the metroline CTA footer expand the full width on mobile devices. As a consequence this will also allow the cta items to expands as well to the full width.

also

  • fixing some BEM stuff

also

  • setting up a z-index to ec-panel because mobile header is overlaying it

@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chameleon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 3:15pm

@stavros-tomas stavros-tomas marked this pull request as ready for review July 8, 2024 15:29
@stavros-tomas stavros-tomas changed the title [WIP][CHUX-690] Make metroline footer cta mobile friendly [CHUX-690] Make metroline footer cta mobile friendly Jul 8, 2024
@stavros-tomas stavros-tomas merged commit fea75d3 into master Jul 10, 2024
4 checks passed
@stavros-tomas stavros-tomas deleted the CHOPS-690-continue-buttons-expand-on-mobile branch July 10, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corinaper corinaper corinaper approved these changes

@Alanebury Alanebury Awaiting requested review from Alanebury Alanebury is a code owner

@raulwwq0 raulwwq0 Awaiting requested review from raulwwq0 raulwwq0 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stavros-tomas @corinaper