[ONL-8253] Added typings #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolandec
approved these changes
Feb 9, 2024
raulwwq0
approved these changes
Feb 9, 2024
corinaper
reviewed
Feb 9, 2024
index.d.ts
Outdated
| object?: string, | ||
| action?: string, | ||
| category?: string, | ||
| value?: string, |
There was a problem hiding this comment.
we might have an error with the value type in a couple of files in EBO, it's mostly string, but we do have numbers in confirmation.vue.
I have asked the data team about these and they told me that for the quote rate (for which we are sending a number) they only check if the value exists, they don't do any calculations with them, so we could just convert them to strings, or we could add number to value type
There was a problem hiding this comment.
Okay, I have enabled numbers as value as well.
corinaper
approved these changes
Feb 9, 2024
corinaper
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add type safety into EBO composables, we need Huha typings first.