Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Check CheckTableCombo allowing to have checkbox in multi combo - … #535

Conversation

zxmulsii151
Copy link

…from release 1.1.0

@eclipse-nebula-bot
Copy link

Can one of the admins verify this patch?

@lcaron
Copy link
Contributor

lcaron commented Oct 3, 2023

Very goog job, thank you for this PR. I've made a few comments

@lcaron
Copy link
Contributor

lcaron commented Jan 22, 2024

@zxmulsii151 Any news about this PR ? If you could fix it, it should be nice because it is very interesting and will provide new features for this widget.

@merks
Copy link
Contributor

merks commented Feb 11, 2024

This seems to be completely stalled. The package names don't appear correct, so I'm not sure how the buidl worked. There are no copyright/license headers on the new files. If this doesn't move forward, we should close it...

@lcaron
Copy link
Contributor

lcaron commented Feb 11, 2024

This functionnality is interesting... Sad that this PR is going to be trashed :'(

@zxmulsii151
Copy link
Author

zxmulsii151 commented Feb 27, 2024 via email

@lcaron
Copy link
Contributor

lcaron commented Feb 27, 2024

Bonjour Olivier (I suppose you're french).

I'll handle this. Thank you for your contribution.

Laurent

@zxmulsii151
Copy link
Author

zxmulsii151 commented Mar 13, 2024 via email

@lcaron
Copy link
Contributor

lcaron commented May 26, 2024

Hi olivier

You code has been included in Nebula : #595

Thank you for your contribution

@lcaron
Copy link
Contributor

lcaron commented May 26, 2024

PR Canceled and replaced by #595

@lcaron lcaron closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants