CDateTime: Fix interference of text editing and opening picker #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, do not try to open picker in text-only mode (triggered by key combo)
|
In order to be able to merge your pull request we need you to complete the Eclipse Contribution Agreement, ECA. These instructions are quite helpful/detailed: |
|
I just tried to fix the ECA problem. As I used another Email for my Eclipse account, I put my GitHub username in the Eclipse profile. Is this sufficient? How do I re-trigger the check? |
|
I think it will be okay:
But I'm not sure why it's taking so long to update the status here... |
|
It looks safe to me, but I don't have deep knowledge... |
|
PR merge. Thank you @christianmichaelis for this bugfix and @merks for your support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #593