Move RadioGroup from incubation to release #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrna
force-pushed
the
radiogroup-to-release
branch
from
83245c0 to
eab6eb9
Compare
merks
requested changes
Jun 4, 2024
|
commit 2: fixed the versions and organization within releng |
mtrna
force-pushed
the
radiogroup-to-release
branch
from
08019dc to
59555ca
Compare
|
In general it's preferred to keep a PR to a single commit which you can do by amending and force pushing changes as described here: |
|
In any case, this looks improved... Let's see how the build goes... |
mtrna
force-pushed
the
radiogroup-to-release
branch
from
59555ca to
434d55d
Compare
|
squashed & force pushed the commits |
|
Thank you! ❤️ |
|
Hi For me it's ok to move from Incubation to release. @wimjongman is it ok for you too ? |
|
Yes. |
|
Since everyone agrees, I will merge. |
|
This is in a latest nightly build: |
|
@merks @lcaron @wimjongman thank you! :) |
|
It's open source great? ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello and thank you for maintaining Nebula!
Would it be possible to add RadioGroup to release? A project I am maintaining is using it since ~2012.
Please let me know here in case there are any additional requirement regarding the transition.
linked issue: #515 (FormattedText to release)