Do not paint over the borders of the widget #603
Conversation
Currently RectangleGroupStrategy sets the clipping to the maximum area the control will need. But in case where the widget size is larger than the area to paint (for example inside a ScrolledComposite) this will result in painting over other widgets (at least on linux). This now do two things: 1) save the original clipping region and recover it afterwards 2) intersect the calculated clipping region with the original to possibly shrink it to the are that is valid for repaint.
|
Did you push this without review? Please lets do the proper thing in the future. |
|
@wimjongman I tried to find a suitable reviewer, but code is marked as "alpha" and no one seem to really work on this (I found some other things but I can workaround them), are you haveing any concerns in not painting over other widgets it seems totally wrong and produces some ugly artifacts at least on linux. |
|
The patch is great as usual, Christoph. Just add me or @lcaron in the future. We are mostly quick to review. The main goal is that way we are kept in the loop of changes. |
|
Alright, I just don't wanted to bore you both with reviews so just let me know if it is too much and you think I should go on with something on my own :-D |
😂sure thing. |
Currently RectangleGroupStrategy sets the clipping to the maximum area the control will need. But in case where the widget size is larger than the area to paint (for example inside a ScrolledComposite) this will result in painting over other widgets (at least on linux).
This now do two things:
possibly shrink it to the are that is valid for repaint.