Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comparison in MaskFormatter #624

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix comparison in MaskFormatter #624

merged 1 commit into from
Dec 2, 2024

Conversation

claussenj
Copy link
Contributor

Fix for #608

@claussenj claussenj mentioned this pull request Dec 2, 2024
Closed
@merks
Copy link
Contributor

merks commented Dec 2, 2024

I revalidated the ECA and it seems fine now.

wimjongman
wimjongman approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@wimjongman wimjongman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wimjongman wimjongman merged commit 2843cbe into EclipseNebula:master Dec 2, 2024
5 checks passed
@wimjongman wimjongman added this to the 3.2.0 milestone Dec 2, 2024
@wimjongman wimjongman linked an issue Dec 2, 2024 that may be closed by this pull request
FormattedText.MaskFormatter Regression #608
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wimjongman wimjongman wimjongman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

FormattedText.MaskFormatter Regression
3 participants
@claussenj @merks @wimjongman