Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time units and calendar when writing netcdf #76

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Add time units and calendar when writing netcdf #76

merged 3 commits into from
Mar 31, 2023

Conversation

SarahAlidoost
Copy link
Member

fixes #74

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SarahAlidoost SarahAlidoost marked this pull request as ready for review March 22, 2023 15:37
BSchilperoort
BSchilperoort approved these changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no issues with the changes, and Yunfei verified that it can now be read by the model evaluation website.

👍

@SarahAlidoost SarahAlidoost merged commit 4d5ec56 into main Mar 31, 2023
@SarahAlidoost SarahAlidoost deleted the fix_issue_74 branch March 31, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BSchilperoort BSchilperoort BSchilperoort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The netCDF files can't be read by modelevaluation website.
2 participants
@SarahAlidoost @BSchilperoort