Fix:service detail res #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
requested changes
Oct 12, 2022
Comment on lines
426
to
437
| self.stop_state_machine( | ||
| f"[V2G2-425] {service_detail_req.service_id} is not offered", | ||
| message, | ||
| ResponseCode.FAILED_SERVICE_ID_INVALID, | ||
| ) | ||
| return |
There was a problem hiding this comment.
This is no reason to stop the communication. we just need to communicate that that service ID is invalid and continue waiting for the next ServiceDetailReq or the next state
ikaratass
force-pushed
the
fix/ServiceDetailRes
branch
from
5f92ce4 to
6137fc9
Compare
ikaratass
force-pushed
the
fix/ServiceDetailRes
branch
from
4bd8dd6 to
46da79f
Compare
shalinnijel2
reviewed
Nov 2, 2022
shalinnijel2
previously approved these changes
Nov 4, 2022
ikaratass
force-pushed
the
fix/ServiceDetailRes
branch
2 times, most recently
from
571fa9a to
2d25484
Compare
tropxy
previously approved these changes
Nov 22, 2022
ikaratass
force-pushed
the
fix/ServiceDetailRes
branch
from
746b7da to
df58534
Compare
ikaratass
force-pushed
the
fix/ServiceDetailRes
branch
from
df58534 to
2a5093b
Compare
shalinnijel2
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix AB#2821
checks if the requested services ids in ServiceDetailReq are ids that were offered by the SECC in ServiceDiscoveryRes. if not, FAILED_SERVICE_ID_INVALID is returned.