Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update udp socket to bind to specific interface #161

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Update udp socket to bind to specific interface #161

merged 3 commits into from
Nov 15, 2022

Conversation

shalinnijel2
Copy link
Contributor

Summary of changes:

  • UDP socket now binds to the specific interface as defined in .env
  • The interface to be used could be passed via start_secc_handler(). This helps remove reliance on env file when required.

@shalinnijel2
Copy link
Contributor Author

shalinnijel2 commented Nov 14, 2022 •
edited
Loading

The way I tested this was by running two instances (2 secc-evcc pairs) of iso15118 sessions on two different interfaces.

danielgordon-switch-ev
danielgordon-switch-ev approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@danielgordon-switch-ev danielgordon-switch-ev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, and it should enable the other stuff you're working on.

Not really for this PR -- but would be good to give some thought about how to bring more automated testing into this repo.

@shalinnijel2 shalinnijel2 merged commit b83b043 into master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielgordon-switch-ev danielgordon-switch-ev danielgordon-switch-ev approved these changes

Assignees

@danielgordon-switch-ev danielgordon-switch-ev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shalinnijel2 @danielgordon-switch-ev