feat: remove argument from UDP server #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tropxy
approved these changes
Dec 14, 2022
snorkman88
deleted the
remove_unnecessary_argument_in_secc_udp_server
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing with Python3.11
reuse_address = Trueis passed as an argument tocreate_datagram_endpoint. This causes the 3.11 interpreter to raise an exception since that keyword argument is no longer supported by the most recent API version because of security concerns.READ MORE HERE
Additionally in
_create_socketline 63:sock.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 0)specifies not to reuse the address therefore there is no need to pass that argument at all.