fix: Schedule entry durations in ChargeParameterDiscoveryRes should add up to departure_time from EVCC (AB#2183) #59

shalinnijel2 · 2022-06-08T11:13:18Z

Added a validation function to check if the schedule returned by the secondary actor is valid
V2G2-303 doesn't seem to be strict though - as V2G2-305 provides provision to EVCC to renegotiate a new schedule in case duration/sales tariff needs are not met.
Added tests for V2G2-303, V2G2-304 and V2G2-761

fix #44

Address V2G2-303, V2G2-304, V2G2-305, V2G2-721

tropxy

check it out

iso15118/secc/controller/simulator.py

iso15118/secc/states/iso15118_2_states.py

tropxy · 2022-06-08T19:03:46Z

tests/secc/states/test_iso15118_2_states.py

+        for schedule_tuples in sa_schedule_tuples:
+            assert schedule_tuples.p_max_schedule is not None
+            schedule_duration = 0
+            if schedule_tuples.p_max_schedule.schedule_entries is not None:
+                start_time = schedule_tuples.p_max_schedule.schedule_entries[
+                    0
+                ].time_interval.start
+
+            for entry in schedule_tuples.p_max_schedule.schedule_entries:
+                schedule_duration += entry.time_interval.start - start_time
+                if entry.time_interval.duration is not None:
+                    schedule_duration += entry.time_interval.duration
+                start_time = entry.time_interval.start


following the same comment as before, I think we can get the last and first entry and do the calculation

Same as above - have done the mod.

tests/secc/states/test_iso15118_2_states.py

tests/secc/states/test_messages.py

fix: Sum of schedule entry durations must match departure time

f880232

Address V2G2-303, V2G2-304, V2G2-305, V2G2-721

shalinnijel2 changed the title ~~fix: Sum of durations in schedule entries must match departure_time from EVCC (AB#2183)~~ fix: Schedule entry durations in ChargeParameterDiscoveryRes should add up to departure_time from EVCC (AB#2183) Jun 8, 2022

Updated simulator to fix failing tests.

7d9bb08

shalinnijel2 requested a review from tropxy June 8, 2022 12:55

Corrected incorrect start time for first sales tariff entry

4251074

tropxy requested changes Jun 8, 2022

View reviewed changes

shalinnijel2 added 2 commits June 8, 2022 22:31

Addressed comments in PR

8894ff2

Updated get_sa_schedule_list() to pass charging limits of the EV

6accd8a

tropxy approved these changes Jun 9, 2022

View reviewed changes

shalinnijel2 merged commit a2b27fa into master Jun 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Schedule entry durations in ChargeParameterDiscoveryRes should add up to departure_time from EVCC (AB#2183) #59

fix: Schedule entry durations in ChargeParameterDiscoveryRes should add up to departure_time from EVCC (AB#2183) #59

shalinnijel2 commented Jun 8, 2022 •

edited by tropxy

Loading

tropxy left a comment

tropxy Jun 8, 2022

shalinnijel2 Jun 8, 2022

fix: Schedule entry durations in ChargeParameterDiscoveryRes should add up to departure_time from EVCC (AB#2183) #59

fix: Schedule entry durations in ChargeParameterDiscoveryRes should add up to departure_time from EVCC (AB#2183) #59

Conversation

shalinnijel2 commented Jun 8, 2022 • edited by tropxy Loading

tropxy left a comment

Choose a reason for hiding this comment

tropxy Jun 8, 2022

Choose a reason for hiding this comment

shalinnijel2 Jun 8, 2022

Choose a reason for hiding this comment

shalinnijel2 commented Jun 8, 2022 •

edited by tropxy

Loading