-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Various Rendering Issues #1085
Comments
It's great having you contribute to this projectWelcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know. |
Can you check in your console if your getting a 429 error message when the avatars don't load, it could be that with so many profiles we're hitting the github API rate limit. Screenshots of console errors would be appreciated too. |
|
console log, above |
Ok yes, we’re hitting the rate limit for the GitHub api |
Yeah, but it's only sometimes, so ig its not really a problem? |
If you visit the page too many times this error appears, but maybe we can add lazy loading so that not all of the avatars are loaded on the grid? |
Sometimes, not all avatars are loaded, 97/100 are loaded, sometimes 99/100. Sometimes, none are loaded, I think how many avatars open also depend a bit on my internet speed. |
I have contacted those that have a 404 profile pic in the past couple of weeks |
Yup, but I think a new release will come soon?
…On Fri, 11 Feb 2022 at 09:41, Krish Gupta ***@***.***> wrote:
I have just loaded it, it is just the username change pfps that aren't
visible. [image: image]
<https://user-images.githubusercontent.com/91655303/153449620-f34d7f58-b668-4abd-95fa-fb8def7545ea.png>
That's kinda related to this problem. I don't think its a big deal if some
pfps are invisible, i mean it is but not as big of a deal than all the pfps
not loading.
But yes, even I'm getting these errors. Thanks for making PR's to resolve
:)
These need to be redeployed to be fixed?
—
Reply to this email directly, view it on GitHub
<#1085 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTLN2KUCI77VXAHMLOLU2SEAHANCNFSM5NYF2QGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Eddie created a release and its fixed on my end, but https://github.com/Recognizeyourself.png gives a issue. |
I found another issue, should I get the description or put it in the thread, please let me know. |
Issues and corresponding pull requests are easier to keep track of if each problem has its own issue. That way they can be worked on by different people too. So please go ahead and open a new issue with as much detail as possible, thanks. |
Ok, it's kinda related to this though but will open a new issue in a bit.
…On Sat, 12 Feb 2022 at 21:36, Emma Dawson ***@***.***> wrote:
I found another issue, should I get the description or put it in the
thread, please let me know.
Issues and corresponding pull requests are easier to keep track of if each
problem has its own issue. That way they can be worked on by different
people too. So please go ahead and open a new issue with as much detail as
possible, thanks.
—
Reply to this email directly, view it on GitHub
<#1085 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUGJUTIOEJE6TIYCK7MAYBLU22AQTANCNFSM5NYF2QGQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Description
First issue I found, is that no profile avatars render for some loads of the site. Second issue, I've found is that the search bar doesn't load for some loads of the site too. Third issue I've found is certain profile avatars don't load, unlike the first issue, it's only for 1-3 avatars though.
The first issue is faced majority of the time, the second and third issue happens only some times, so couldn't attach ss.
Screenshots
Additional information
No response
The text was updated successfully, but these errors were encountered: