Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

[FEATURE] Add Dark Mode #1838

Closed
Keshraf opened this issue Oct 1, 2022 · 15 comments
Closed

[FEATURE] Add Dark Mode #1838

Keshraf opened this issue Oct 1, 2022 · 15 comments
Assignees
Labels

Comments

@Keshraf
Copy link

Keshraf commented Oct 1, 2022

Description

EddieHub is a community of developers and open-source enthusiasts. And who doesn't love dark mode more than them? I would like to add dark mode support.

Please assign this issue to me and attach the Hackoberfest label.

Screenshots

No response

Additional information

🌚

@Keshraf Keshraf added the ⭐ goal: addition undefined label Oct 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@Keshraf
Copy link
Author

Keshraf commented Oct 1, 2022

Hey @vasucp1207, actually I added this issue as I wanted to work on it. I am waiting for a maintainer to assign this issue to me. You can create more issues and work on them instead

@gptkrsh
Copy link
Contributor

gptkrsh commented Oct 1, 2022

We would want it on the navbar, also we need to look up media queries as well

@vasucp1207
Copy link
Contributor

Sorry, @Keshraf I do not read the full description.

@Keshraf
Copy link
Author

Keshraf commented Oct 1, 2022

Sorry, @Keshraf I do not read the full description.

Not a problem. Don't worry about it. There are a lot more things you contribute to!

@EmmaDawsonDev
Copy link
Member

Sure @Keshraf go ahead. Please make this addition to the next-js branch instead of the current main branch so that it will be included in v2 of linkfree

@Keshraf
Copy link
Author

Keshraf commented Oct 1, 2022

Okay understood. Thank you for letting me know!

@Vedant-Manjrekar
Copy link
Contributor

Hey actually i have worked on this issue already, as it was raised earlier as well, so if @Keshraf is not able to implement this feature i can help, just do let me know.

@EmmaDawsonDev
Copy link
Member

Hey actually i have worked on this issue already, as it was raised earlier as well, so if @Keshraf is not able to implement this feature i can help, just do let me know.

Oh sorry, I didn't know someone was already working on this. What's the issue number?

@Vedant-Manjrekar
Copy link
Contributor

Hey actually i have worked on this issue already, as it was raised earlier as well, so if @Keshraf is not able to implement this feature i can help, just do let me know.

Oh sorry, I didn't know someone was already working on this. What's the issue number?

It's #1032

@EmmaDawsonDev
Copy link
Member

Ok, this is a bit difficult since the issue was never assigned and the last message is from august so it looks abandoned but we can do like this.

Vedant - make your PR to the main branch as it looks like you made yours in prime react (no need to ask to make a PR)
Keshraf - make a version for the next-js branch instead.

hope that works for everyone

@Keshraf
Copy link
Author

Keshraf commented Oct 1, 2022

That works for me!

@Vedant-Manjrekar
Copy link
Contributor

Works for me as well.

@ManishBisht777
Copy link
Contributor

ManishBisht777 commented Jan 27, 2023

there is an issue opened similar to this #2957
I want to work on this @Keshraf are you working on this

@SaraJaoude
Copy link
Member

Thank you for raising this idea, but I will be closing this issue as #2957 deals with the same subject and has more discussions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants